Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Alert animation not executed on safari #2389

Closed
3 tasks done
Acika00mk opened this issue Feb 6, 2024 · 0 comments · Fixed by #2394 or #2379
Closed
3 tasks done

[Bug]: Alert animation not executed on safari #2389

Acika00mk opened this issue Feb 6, 2024 · 0 comments · Fixed by #2394 or #2379
Assignees
@jeripeierSBB
Labels
type: bug 🐛 Something isn't working

Comments

@Acika00mk
Copy link

Preflight Checklist

Bug type

Functionality

It affects the following packages

Components

Which version of Lyne Components are you using

0.44.1

Operating system

MacOS

Browser / Browser version

Safari

Input mode

None

Additional settings

No response

What happened?

The alertsare not displayed on load on Safari

Link : https://int-www.sbb.ch/de/meta/seiten/suche.html
Connected issue : https://flow.sbb.ch/browse/WEBEX-1612

Steps to reproduce the issue

Open link

https://int-www.sbb.ch/de/meta/seiten/suche.html

observe the getttobox (alert) is not shown

Compare it with Chrome on same link

Relevant log output

No response
@Acika00mk Acika00mk added the type: bug 🐛 Something isn't working label Feb 6, 2024
@jeripeierSBB jeripeierSBB changed the title [Bug]: Aler animation not executed on safari [Bug]: Alert animation not executed on safari Feb 6, 2024
@jeripeierSBB jeripeierSBB self-assigned this Feb 6, 2024
@jeripeierSBB jeripeierSBB mentioned this issue Feb 8, 2024
Merged
jeripeierSBB added a commit that referenced this issue Feb 8, 2024
@jeripeierSBB
fix(sbb-alert): refactor animation to properly work in Safari (#2394)
30bf7c1 
BREAKING CHANGE: renamed `willPresent` event to `willOpen` and `didPresent` to `didOpen`.

Closes #2389
@github-actions github-actions bot mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeripeierSBB jeripeierSBB

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@Acika00mk @jeripeierSBB