Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-status): allow custom icons #2403

Merged
merged 3 commits into from
Feb 14, 2024
Merged

feat(sbb-status): allow custom icons #2403

merged 3 commits into from
Feb 14, 2024

Conversation

jeripeierSBB
Copy link
Contributor

Closes #2398

@jeripeierSBB jeripeierSBB added pr: peer review required A peer review is required for this pull request pr: lead review required A lead review is required for this pull request pr: ux review required A ux review is required for this pull request labels Feb 8, 2024
kyubisation
kyubisation approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Feb 8, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2403 February 8, 2024 16:23 Inactive
DavideMininni-Fincons
DavideMininni-Fincons approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@7307d0f). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2403   +/-   ##
=======================================
  Coverage        ?   93.81%           
=======================================
  Files           ?      228           
  Lines           ?    23521           
  Branches        ?     2069           
=======================================
  Hits            ?    22066           
  Misses          ?     1417           
  Partials        ?       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeripeierSBB jeripeierSBB added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Feb 8, 2024
@jeripeierSBB jeripeierSBB added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Feb 14, 2024
@jeripeierSBB jeripeierSBB merged commit 56b4068 into main Feb 14, 2024
17 of 19 checks passed
@jeripeierSBB jeripeierSBB deleted the status-with-custom-icon branch February 14, 2024 14:50
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@DavideMininni-Fincons DavideMininni-Fincons DavideMininni-Fincons approved these changes

@mcilurzo mcilurzo Awaiting requested review from mcilurzo

Assignees
No one assigned
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: Overwritable icon in sbb-status
4 participants
@jeripeierSBB @codecov-commenter @kyubisation @DavideMininni-Fincons