fix(sbb-radio-group, sbb-tab-group): avoid incorrect setup if component is invisible during init #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible check to avoid incorrect setup when component is invisible during initialization
github-actions
bot
added
the
pr: peer review required
jeripeierSBB
changed the title
jeripeierSBB
changed the title
jeripeierSBB
changed the title
jeripeierSBB
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
=======================================
Coverage ? 93.69%
=======================================
Files ? 265
Lines ? 23526
Branches ? 2048
=======================================
Hits ? 22042
Misses ? 1451
Partials ? 33 ☔ View full report in Codecov by Sentry. |
dauriamarco
approved these changes
Feb 29, 2024
github-actions
bot
added
pr: peer review approved
In the checkbox it's a different case because there we only check it whenever a key was pressed so it should be still ok. There it's also not the group which has to manage it's children state. |
github-actions
bot
added
the
pr: lead review approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.