Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(multiple): remove undefined type from titleLevel #2447

Merged
merged 3 commits into from
Feb 29, 2024
Merged

docs(multiple): remove undefined type from titleLevel #2447

merged 3 commits into from
Feb 29, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB
docs(multiple): remove undefined type from titleLevel
ca3953b 
BREAKING CHANGE: rename `TitleLevel` to `SbbTitleLevel`
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Feb 29, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2447 February 29, 2024 11:09 Inactive
kyubisation
kyubisation approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/components/skiplink-list/skiplink-list.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Feb 29, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2447 February 29, 2024 12:07 Inactive
@jeripeierSBB jeripeierSBB merged commit c2532cd into main Feb 29, 2024
17 checks passed
@jeripeierSBB jeripeierSBB deleted the title-level branch February 29, 2024 13:34
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Feb 29, 2024
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeripeierSBB @kyubisation