Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-navigation): remove navigation section divider #2473

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

dauriamarco
Copy link
Contributor

Closes #2465

@dauriamarco dauriamarco added pr: peer review required A peer review is required for this pull request pr: ux review required A ux review is required for this pull request labels Mar 11, 2024
@dauriamarco dauriamarco self-assigned this Mar 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@4f8f309). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2473   +/-   ##
=======================================
  Coverage        ?   93.68%           
=======================================
  Files           ?      297           
  Lines           ?    24399           
  Branches        ?     2035           
=======================================
  Hits            ?    22857           
  Misses          ?     1509           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 11, 2024
@dauriamarco dauriamarco merged commit 71c1412 into main Mar 12, 2024
27 checks passed
@dauriamarco dauriamarco deleted the feat/remove-nav-divider branch March 12, 2024 10:07
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: ux review required A ux review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: remove divider in navigation (second level)
3 participants