Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract sbb-overlay from sbb-dialog #2476

Closed
dauriamarco opened this issue Mar 12, 2024 · 0 comments · Fixed by #2477 or #2536
Closed

refactor: extract sbb-overlay from sbb-dialog #2476

dauriamarco opened this issue Mar 12, 2024 · 0 comments · Fixed by #2477 or #2536
Assignees
@dauriamarco

Comments

@dauriamarco
Copy link
Contributor

We want to extract the functionality of the sbb-overlay from the sbb-dialog.
The sbb-overlay is the fullscreen variant of the dialog and we want to separate it into its own component.
Check if the overlay functionality can be extracted into a base class.
@dauriamarco dauriamarco self-assigned this Mar 12, 2024
@dauriamarco dauriamarco mentioned this issue Mar 12, 2024
Merged
28 tasks
jeripeierSBB added a commit that referenced this issue Apr 2, 2024
@dauriamarco @jeripeierSBB
feat(sbb-overlay): extract sbb-overlay component from dialog (#2477)
5ea4fb7 
Closes #2476
Closes #2470

Co-authored-by: Jeremias Peier <jeremias.peier@sbb.ch>
@github-actions github-actions bot mentioned this issue Apr 2, 2024
Merged
@github-actions github-actions bot mentioned this issue Jun 17, 2024
Closed
This was referenced Jun 25, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dauriamarco dauriamarco

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dauriamarco