Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-navigation): fix navigation actions contrast ratio #2481

Merged
merged 8 commits into from
Mar 14, 2024
Merged

fix(sbb-navigation): fix navigation actions contrast ratio #2481

merged 8 commits into from
Mar 14, 2024

Conversation

dauriamarco
Copy link
Contributor

@dauriamarco dauriamarco commented Mar 12, 2024 •
edited
Loading

  • Adds a dash icon next to the active navigation actions in the section.
  • Fixes the active and reset mechanism of the markers no open/close.
  • Disables animation on resize.

@dauriamarco dauriamarco added pr: peer review required A peer review is required for this pull request pr: ux review required A ux review is required for this pull request labels Mar 12, 2024
@dauriamarco dauriamarco self-assigned this Mar 12, 2024
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Mar 12, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2481 March 12, 2024 22:00 Inactive
@dauriamarco dauriamarco force-pushed the fix/nav-actions-contrast-ratio branch from 36d31aa to 2e0285f Compare March 13, 2024 08:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@e8b90e8). Click here to learn what that means.

Files Patch % Lines
src/components/navigation/navigation/navigation.ts 94.44% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2481   +/-   ##
=======================================
  Coverage        ?   93.67%           
=======================================
  Files           ?      298           
  Lines           ?    24382           
  Branches        ?     2035           
=======================================
  Hits            ?    22841           
  Misses          ?     1508           
  Partials        ?       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2481 March 13, 2024 08:50 Inactive
@dauriamarco dauriamarco marked this pull request as ready for review March 13, 2024 13:48
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 13, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2481 March 13, 2024 13:57 Inactive
@dauriamarco dauriamarco force-pushed the fix/nav-actions-contrast-ratio branch from 806ed35 to 4914239 Compare March 13, 2024 14:12
@github-actions github-actions bot temporarily deployed to preview-pr2481 March 13, 2024 14:21 Inactive
@dauriamarco dauriamarco force-pushed the fix/nav-actions-contrast-ratio branch from 4914239 to 4f1a989 Compare March 14, 2024 00:56
jeripeierSBB
jeripeierSBB approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the fixes!

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 14, 2024
@dauriamarco dauriamarco removed the pr: ux review required A ux review is required for this pull request label Mar 14, 2024
@dauriamarco dauriamarco added pr: ux review approved Pull request has been approved by a ux review and removed pr: peer review required A peer review is required for this pull request labels Mar 14, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 14, 2024
@dauriamarco dauriamarco merged commit f605a1e into main Mar 14, 2024
27 of 29 checks passed
@dauriamarco dauriamarco deleted the fix/nav-actions-contrast-ratio branch March 14, 2024 07:20
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Mar 14, 2024
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 25, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@mcilurzo mcilurzo Awaiting requested review from mcilurzo

Assignees

@dauriamarco dauriamarco

Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: ux review approved Pull request has been approved by a ux review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dauriamarco @codecov-commenter @jeripeierSBB