Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename component name from sbb-screenreader-only to sbb-screeen-reader-only #2520

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

jeripeierSBB
Copy link
Contributor

As in English language screen reader is written in two words, we like to change the naming and also aligning it to existing SASS mixin name.

BREAKING CHANGE: renamed component sbb-screenreader-only to sbb-screeen-reader-only.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 25, 2024
@jeripeierSBB jeripeierSBB changed the title refactor(sbb-screen-reader-only): rename component name from sbb-screenreader-only to sbb-screeen-reader-only refactor: rename component name from sbb-screenreader-only to sbb-screeen-reader-only Mar 25, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2520 March 25, 2024 15:31 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 90.16393% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@1266a21). Click here to learn what that means.

Files Patch % Lines
src/components/core/timetable/access-leg-helper.ts 33.33% 2 Missing ⚠️
src/components/option/option/option.ts 33.33% 2 Missing ⚠️
src/components/timetable-row/timetable-row.ts 75.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2520   +/-   ##
=======================================
  Coverage        ?   93.14%           
=======================================
  Files           ?      299           
  Lines           ?    24930           
  Branches        ?     2038           
=======================================
  Hits            ?    23222           
  Misses          ?     1679           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…eenreader-only` to `sbb-screeen-reader-only`

BREAKING CHANGE: renamed `sbb-screenreader-only` to `sbb-screeen-reader-only`
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Mar 27, 2024
@jeripeierSBB jeripeierSBB merged commit 6fbf085 into main Mar 27, 2024
21 checks passed
@jeripeierSBB jeripeierSBB deleted the screenreader-only-refactoring branch March 27, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants