-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename component name from sbb-screenreader-only
to sbb-screeen-reader-only
#2520
Conversation
sbb-screenreader-only
to sbb-screeen-reader-only
sbb-screenreader-only
to sbb-screeen-reader-only
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
=======================================
Coverage ? 93.14%
=======================================
Files ? 299
Lines ? 24930
Branches ? 2038
=======================================
Hits ? 23222
Misses ? 1679
Partials ? 29 ☔ View full report in Codecov by Sentry. |
…eenreader-only` to `sbb-screeen-reader-only` BREAKING CHANGE: renamed `sbb-screenreader-only` to `sbb-screeen-reader-only`
79d23d4
to
b8df5b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
As in English language
screen reader
is written in two words, we like to change the naming and also aligning it to existing SASS mixin name.BREAKING CHANGE: renamed component
sbb-screenreader-only
tosbb-screeen-reader-only
.