fix(sbb-form-field): remove label property and attribute #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
=======================================
Coverage ? 93.19%
=======================================
Files ? 301
Lines ? 24921
Branches ? 2029
=======================================
Hits ? 23225
Misses ? 1667
Partials ? 29 ☔ View full report in Codecov by Sentry. |
TomMenga
added
pr: peer review approved
In order to support SSR we have to remove the label property. As replacement the `<label>` tag should be used. BREAKING CHANGE: `label` property and attribute of `<sbb-form-field>` was removed. Use `<label>` tag inside `<sbb-form-field>` to provide the label information.
jeripeierSBB
force-pushed
the
form-field-label-prop-removal
branch
from
0abe60b
to
2c0aff7
Compare
github-actions
bot
added
the
pr: lead review approved
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support SSR we have to remove the label property. As replacement the
<label>tag should be used.BREAKING CHANGE:
labelproperty and attribute of<sbb-form-field>was removed. Use<label>tag inside<sbb-form-field>to provide the label information. E.g.<sbb-form-field label="Example">...</sbb-form-field>becomes<sbb-form-field><label>Example</label>...</sbb-form-field>