Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update import paths missed in the migration #2579

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

kyubisation
Copy link
Contributor

This PR fixes the remaining missed import paths that were not adapted. It additionally adds a vite plugin check, to ensure the build would break, if an illegal import was used.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 15, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for fixing my bugs :D

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8054d9a). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2579   +/-   ##
=======================================
  Coverage        ?   93.18%           
=======================================
  Files           ?      315           
  Lines           ?    25381           
  Branches        ?     2062           
=======================================
  Hits            ?    23652           
  Misses          ?     1696           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyubisation kyubisation merged commit 9c90fa8 into main Apr 15, 2024
23 checks passed
@kyubisation kyubisation deleted the fix-imports branch April 15, 2024 11:53
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants