Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-alert): add size s #2591

Merged
merged 4 commits into from
Apr 17, 2024
Merged

feat(sbb-alert): add size s #2591

merged 4 commits into from
Apr 17, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Apr 16, 2024

Preflight Checklist

Issue

This PR Closes #2586

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • add size='s' for sbb-alert

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Apr 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 16, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2591 April 16, 2024 08:51 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM, did not check the output :)

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM, did not check the output :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@ddfd884). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2591   +/-   ##
=======================================
  Coverage        ?   93.18%           
=======================================
  Files           ?      316           
  Lines           ?    25389           
  Branches        ?     2063           
=======================================
  Hits            ?    23660           
  Misses          ?     1696           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2591 April 16, 2024 09:29 Inactive
@DavideMininni-Fincons DavideMininni-Fincons added the pr: ux review required A ux review is required for this pull request label Apr 16, 2024
@github-actions github-actions bot added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Apr 17, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 3a82c67 into main Apr 17, 2024
21 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/alert-size-s branch April 17, 2024 12:30
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: ux review approved Pull request has been approved by a ux review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lean: alert: size S
4 participants