Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-navigation): fix active and focus handling #2471

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

dauriamarco
Copy link
Contributor

Fix navigation accessibility.

@dauriamarco dauriamarco added the pr: lead review required A lead review is required for this pull request label Mar 11, 2024
@dauriamarco dauriamarco self-assigned this Mar 11, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 11, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was fast ;)

@github-actions github-actions bot temporarily deployed to preview-pr2471 March 11, 2024 15:57 Inactive
@dauriamarco dauriamarco force-pushed the fix/navigation-active-handling branch from d8d8771 to 2542aff Compare March 12, 2024 10:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@71c1412). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2471   +/-   ##
=======================================
  Coverage        ?   93.68%           
=======================================
  Files           ?      297           
  Lines           ?    24406           
  Branches        ?     2031           
=======================================
  Hits            ?    22864           
  Misses          ?     1509           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@github-actions github-actions bot added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Mar 12, 2024
@dauriamarco dauriamarco merged commit ea81790 into main Mar 12, 2024
21 checks passed
@dauriamarco dauriamarco deleted the fix/navigation-active-handling branch March 12, 2024 11:00
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants