-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-overlay): extract sbb-overlay
component from dialog
#2477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2477 +/- ##
=======================================
Coverage ? 93.19%
=======================================
Files ? 303
Lines ? 25181
Branches ? 2057
=======================================
Hits ? 23467
Misses ? 1685
Partials ? 29 ☔ View full report in Codecov by Sentry. |
8fbff4f
to
3782280
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job :D
Just some small things to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! some notes added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add sbb-overlay to typography.scss where we have the lists of components to hide until defined ("// Hiding components until they are instantiated")
3782280
to
6f8a0be
Compare
6f8a0be
to
200ba49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good, styling seems to need improvement
3422ebe
to
c640a23
Compare
c640a23
to
eeaa464
Compare
2824b55
to
ae0772a
Compare
Preflight Checklist
Issue
This PR Closes #2476 #2470
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
sbb-overlay
component from dialogBrowsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information