Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-overlay): extract sbb-overlay component from dialog #2477

Merged
merged 14 commits into from
Apr 2, 2024

Conversation

dauriamarco
Copy link
Contributor

@dauriamarco dauriamarco commented Mar 12, 2024

Preflight Checklist

Issue

This PR Closes #2476 #2470

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • extract sbb-overlay component from dialog

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dauriamarco dauriamarco added the pr: peer review required A peer review is required for this pull request label Mar 12, 2024
@dauriamarco dauriamarco self-assigned this Mar 12, 2024
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Mar 12, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 12, 2024 13:59 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@433c57c). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2477   +/-   ##
=======================================
  Coverage        ?   93.19%           
=======================================
  Files           ?      303           
  Lines           ?    25181           
  Branches        ?     2057           
=======================================
  Hits            ?    23467           
  Misses          ?     1685           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2477 March 12, 2024 14:39 Inactive
@dauriamarco dauriamarco marked this pull request as ready for review March 12, 2024 15:12
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 12, 2024
@dauriamarco dauriamarco added the pr: ux review required A ux review is required for this pull request label Mar 12, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 12, 2024 15:23 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 13, 2024 08:04 Inactive
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :D
Just some small things to fix

src/components/overlay/overlay.e2e.ts Show resolved Hide resolved
src/components/overlay/overlay.spec.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.stories.ts Show resolved Hide resolved
src/components/overlay/overlay.spec.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.ts Show resolved Hide resolved
src/components/overlay/overlay.ts Outdated Show resolved Hide resolved
src/components/overlay/readme.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! some notes added

src/components/overlay/readme.md Outdated Show resolved Hide resolved
src/components/overlay/overlay.stories.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.stories.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.stories.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.stories.ts Outdated Show resolved Hide resolved
src/components/dialog/dialog-content/dialog-content.ts Outdated Show resolved Hide resolved
src/components/dialog/dialog-title/dialog-title.spec.ts Outdated Show resolved Hide resolved
src/components/dialog/dialog-title/readme.md Outdated Show resolved Hide resolved
src/components/dialog/dialog/dialog.spec.ts Outdated Show resolved Hide resolved
src/components/dialog/dialog/readme.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add sbb-overlay to typography.scss where we have the lists of components to hide until defined ("// Hiding components until they are instantiated")

@github-actions github-actions bot temporarily deployed to preview-pr2477 March 18, 2024 09:38 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 18, 2024 10:25 Inactive
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work!

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Mar 20, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good, styling seems to need improvement

src/components/overlay/overlay.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.scss Outdated Show resolved Hide resolved
src/components/overlay/overlay.scss Outdated Show resolved Hide resolved
src/components/overlay/overlay.scss Outdated Show resolved Hide resolved
src/components/overlay/overlay.scss Outdated Show resolved Hide resolved
src/components/overlay/overlay.scss Outdated Show resolved Hide resolved
src/components/overlay/overlay.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.ts Outdated Show resolved Hide resolved
src/components/overlay/overlay.ts Show resolved Hide resolved
src/components/overlay/readme.md Show resolved Hide resolved
@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-overlay branch 2 times, most recently from 3422ebe to c640a23 Compare March 21, 2024 07:28
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 21, 2024 07:38 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 27, 2024 13:43 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 27, 2024 14:01 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2477 March 27, 2024 14:42 Inactive
@github-actions github-actions bot added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Mar 27, 2024
@jeripeierSBB jeripeierSBB merged commit 5ea4fb7 into main Apr 2, 2024
15 of 17 checks passed
@jeripeierSBB jeripeierSBB deleted the feat/introduce-sbb-overlay branch April 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: extract sbb-overlay from sbb-dialog
6 participants