Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate 'toggleDatasetEntry' calls to 'toggleAttribute' #2488

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

TomMenga
Copy link
Contributor

Removed toggleDatasetEntry usages in favor of element.toggleAttribute

@TomMenga TomMenga added the pr: peer review required A peer review is required for this pull request label Mar 13, 2024
@TomMenga TomMenga self-assigned this Mar 13, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won! :-) Thanks! Not sure if we should keep the migration script?

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.55556% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@af86d2f). Click here to learn what that means.

Files Patch % Lines
src/components/file-selector/file-selector.ts 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2488   +/-   ##
=======================================
  Coverage        ?   93.67%           
=======================================
  Files           ?      298           
  Lines           ?    24334           
  Branches        ?     2027           
=======================================
  Hits            ?    22795           
  Misses          ?     1506           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomMenga
Copy link
Contributor Author

TomMenga commented Mar 13, 2024

You won! :-) Thanks! Not sure if we should keep the migration script?

The idea was to keep it for one/two weeks top just in case someone needs it.
Most likely, nobody will use it though.
Also, it might be useful to have it in the history for future reference (as an example of when (if) we'll implement migration scripts for breaking changes)

@jeripeierSBB
Copy link
Contributor

You won! :-) Thanks! Not sure if we should keep the migration script?

The idea was to keep it for one/two weeks top just in case someone needs it. Most likely, nobody will use it though. Also, it might be useful to have it in the history for future reference (as an example of when (if) we'll implement migration scripts for breaking changes)

it's ok :)

@TomMenga TomMenga merged commit 1134b8d into main Mar 13, 2024
26 checks passed
@TomMenga TomMenga deleted the refactor/remove-data-set-entry branch March 13, 2024 13:50
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants