Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 'vite-plugin-turbosnap' dependency #2495

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Mar 18, 2024

With Storybook 8.0 they started supporting the generation of preview-stats.json (used by turbosnap) with Vite.
We don't need the external plugin anymore 😄

Ps. Chromatic will fail until we merge this fix

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@baede50). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2495   +/-   ##
=======================================
  Coverage        ?   93.65%           
=======================================
  Files           ?      298           
  Lines           ?    24366           
  Branches        ?     2036           
=======================================
  Hits            ?    22821           
  Misses          ?     1512           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomMenga TomMenga self-assigned this Mar 18, 2024
@TomMenga TomMenga added the pr: lead review required A lead review is required for this pull request label Mar 18, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@github-actions github-actions bot added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Mar 18, 2024
@TomMenga TomMenga merged commit d96ae68 into main Mar 18, 2024
31 checks passed
@TomMenga TomMenga deleted the chore/fix-turbosnap branch March 18, 2024 09:36
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants