refactor(sbb-calendar): implement initial support for other date libraries #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aries BREAKING CHANGE: The `SbbDatepicker` property `selectedDate` has been renamed to `selected`. This also applies to the attribute `selected-date`, which has been renamed to `selected`. Additionally the `DateAdapter` (and `NativeDateAdapter`) have been superficially refactored. An important change is that the month is now `1`-based, instead of `0`-based.
github-actions
bot
added
the
pr: peer review required
jeripeierSBB
requested changes
Mar 21, 2024
jeripeierSBB
requested changes
Mar 21, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2511 +/- ##
=======================================
Coverage ? 93.85%
=======================================
Files ? 299
Lines ? 24495
Branches ? 2021
=======================================
Hits ? 22990
Misses ? 1476
Partials ? 29 ☔ View full report in Codecov by Sentry. |
jeripeierSBB
approved these changes
Mar 21, 2024
github-actions
bot
added
the
pr: lead review approved
MarioCastigliano
approved these changes
Mar 21, 2024
github-actions
bot
added
pr: peer review approved
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us in the future to support different date libraries. However, this is only the implementation for the calendar. Datepicker will be done in a different PR.
BREAKING CHANGE: The
SbbDatepickerpropertyselectedDatehas been renamed toselected. This also applies to the attributeselected-date, which has been renamed toselected. Additionally theDateAdapter(andNativeDateAdapter) have been superficially refactored. An important change is that the month is now1-based, instead of0-based.