Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sbb-checkbox, sbb-toggle-check): stabilize tests with retries #2518

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 25, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Can you maybe add a comment to explain why the retries are necessary, so in the future we can check whether they can be removed?

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 25, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2518 March 25, 2024 10:02 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@3fae552). Click here to learn what that means.

❗ Current head 08f0b78 differs from pull request most recent head e95c8b3. Consider uploading reports for the commit e95c8b3 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2518   +/-   ##
=======================================
  Coverage        ?   93.14%           
=======================================
  Files           ?      301           
  Lines           ?    24954           
  Branches        ?     2041           
=======================================
  Hits            ?    23244           
  Misses          ?     1681           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeripeierSBB jeripeierSBB merged commit 9135de6 into main Mar 25, 2024
17 checks passed
@jeripeierSBB jeripeierSBB deleted the stabilize-tests branch March 25, 2024 10:47
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants