Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: stabilize a couple of tests #2525

Merged
merged 9 commits into from
Mar 27, 2024
Merged

test: stabilize a couple of tests #2525

merged 9 commits into from
Mar 27, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB jeripeierSBB changed the title test: stabilize some tests test: stabilize a couple of tests Mar 26, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 26, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2525 March 26, 2024 13:57 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@2a9f60e). Click here to learn what that means.

❗ Current head 485a03f differs from pull request most recent head 31d5ede. Consider uploading reports for the commit 31d5ede to get more accurate results

Files Patch % Lines
...ponents/core/testing/private/a11y-tree-snapshot.ts 42.85% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2525   +/-   ##
=======================================
  Coverage        ?   93.14%           
=======================================
  Files           ?      301           
  Lines           ?    24958           
  Branches        ?     2038           
=======================================
  Hits            ?    23248           
  Misses          ?     1681           
  Partials        ?       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyubisation
kyubisation approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/components/autocomplete/autocomplete.spec.ts Outdated Show resolved Hide resolved
src/components/menu/menu/menu.spec.ts Outdated Show resolved Hide resolved
src/components/option/optgroup/optgroup.spec.ts Outdated Show resolved Hide resolved
src/components/option/optgroup/optgroup.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 26, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2525 March 26, 2024 15:31 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2525 March 26, 2024 19:40 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2525 March 27, 2024 07:07 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2525 March 27, 2024 07:41 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2525 March 27, 2024 07:59 Inactive
TomMenga
TomMenga approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just a nitpick

src/components/core/testing/private/a11y-tree-snapshot.ts Show resolved Hide resolved
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Mar 27, 2024
@jeripeierSBB jeripeierSBB merged commit 4be77c9 into main Mar 27, 2024
18 checks passed
@jeripeierSBB jeripeierSBB deleted the fix-tests branch March 27, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@TomMenga TomMenga TomMenga approved these changes

Assignees
No one assigned
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeripeierSBB @codecov-commenter @kyubisation @TomMenga