Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure entry points #2575

Merged
merged 3 commits into from
Apr 11, 2024
Merged

refactor: restructure entry points #2575

merged 3 commits into from
Apr 11, 2024

Conversation

kyubisation
Copy link
Contributor

BREAKING CHANGE: The entry points for the @sbb-esta/lyne-components have changed from extension-less to including the extension (e.g. @sbb-esta/lyne-components/button to @sbb-esta/lyne-components/button.js).

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@374d7b7). Click here to learn what that means.

❗ Current head a9ee73a differs from pull request most recent head 2dd9043. Consider uploading reports for the commit 2dd9043 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2575   +/-   ##
=======================================
  Coverage        ?   93.13%           
=======================================
  Files           ?      201           
  Lines           ?    25175           
  Branches        ?     2058           
=======================================
  Hits            ?    23446           
  Misses          ?     1696           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 11, 2024
@kyubisation kyubisation merged commit 3d4c8ab into main Apr 11, 2024
14 checks passed
@kyubisation kyubisation deleted the refactor-restructure branch April 11, 2024 13:51
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Apr 11, 2024
@github-actions github-actions bot requested a deployment to preview-main April 11, 2024 13:59 In progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants