Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefix all css variable names #2609

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: prefix all css variable names #2609

merged 1 commit into from
Apr 23, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

BREAKING CHANGE: CSS variable `--image-border-radius` has been renamed
to `--sbb-image-border-radius`.
CSS variable `--form-field-error-min-height` has been renamed
to `--sbb-form-field-error-min-height`
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (e6397df) to head (6a7e41f).
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2609   +/-   ##
=======================================
  Coverage   93.18%   93.19%           
=======================================
  Files         316      316           
  Lines       25389    25403   +14     
  Branches     2063     2063           
=======================================
+ Hits        23660    23674   +14     
  Misses       1696     1696           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Apr 23, 2024
@jeripeierSBB jeripeierSBB merged commit 788cef7 into main Apr 23, 2024
26 checks passed
@jeripeierSBB jeripeierSBB deleted the fix-css-vars branch April 23, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants