Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use localName instead of tagName #2612

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Conversation

MarioCastigliano
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #2569

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.22%. Comparing base (e6397df) to head (566aade).
Report is 14 commits behind head on main.

Files Patch % Lines
src/components/autocomplete/autocomplete.ts 0.00% 1 Missing ⚠️
...ts/form-field/form-field-clear/form-field-clear.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
+ Coverage   93.18%   93.22%   +0.03%     
==========================================
  Files         316      316              
  Lines       25389    25317      -72     
  Branches     2063     2064       +1     
==========================================
- Hits        23660    23602      -58     
+ Misses       1696     1682      -14     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work 😃

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 24, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MarioCastigliano MarioCastigliano merged commit 9ca43ca into main Apr 24, 2024
29 of 30 checks passed
@MarioCastigliano MarioCastigliano deleted the refactor/local-name branch April 24, 2024 07:12
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: use localName instead of tagName
4 participants