Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devise_token_auth depends on vulnerable devise version #1273

Closed
danbartlett opened this issue Mar 21, 2019 · 1 comment
Closed

devise_token_auth depends on vulnerable devise version #1273

danbartlett opened this issue Mar 21, 2019 · 1 comment

Comments

@danbartlett
Copy link

danbartlett commented Mar 21, 2019

There is a new security alert in devise, that requires updating to 4.6.0 or later:

image

See: heartcombo/devise#4981

Unfortunately it seems devise_token_auth (v1.0.0) won't allow this update as it depends on < 4.6

$ bundle update devise
The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x86-mswin32, x64-mingw32, java. To add those platforms to the bundle, run `bundle lock --add-platform x86-mingw32 x86-mswin32 x64-mingw32 java`.
Fetching gem metadata from https://rubygems.org/..........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "devise":
  In Gemfile:
    devise (>= 4.6.0)

    devise_token_auth was resolved to 1.0.0, which depends on
      devise (< 4.6, > 3.5.2)
$ bundle show devise_token_auth
/Users/danbartlett/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/devise_token_auth-1.0.0
@danbartlett
Copy link
Author

danbartlett commented Mar 23, 2019

Just realised I wasn't on the latest version of devise_token_auth. Once I updated to the latest version—1.1.0, via bundle update—this wasn't an issue and I could specify the minimum required version of devise without conflict 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant