Sharing iP code quality feedback [for @lynnlow175] - Round 2

[soc-se-script]

@lynnlow175 We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, so that you can avoid similar problems in your tP code (which will be graded more strictly for code quality).

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues 👍

Aspect: Naming boolean variables/methods

No easy-to-detect issues 👍

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

Example from src/main/java/duke/Parser.java lines 258-264:

    /**
     * Check for identical task string representation in the task list.
     *
     * @param task includes event, todo and deadline
     * @param taskList an array of tasks
     * @param hasDuplicate a flag to check if there is a duplicate task
     */

Example from src/main/java/duke/Task.java lines 35-37:

    /**
     * A method that sets the done flag to false.
     */

Example from src/main/java/duke/Ui.java lines 175-177:

    /**
     * Empty find command description.
     */

Suggestion: Ensure method/class header comments follow the format specified in the coding standard, in particular, the phrasing of the overview statement.

Aspect: Recent Git Commit Message

possible problems in commit 0d6ffe9:

A-MoreErrorHandling

• Not in imperative mood (?)

possible problems in commit 4345771:

edited Ui.png

• Not in imperative mood (?)

possible problems in commit 0dc22f9:

Ui.png

• Perhaps too short (?)

Suggestion: Follow the given conventions for Git commit messages for future commits (do not modify past commit messages as doing so will change the commit timestamp that we used to detect your commit timings).

Aspect: Binary files in repo

No easy-to-detect issues 👍

---

❗ You are not required to (but you are welcome to) fix the above problems in your iP, unless you have been separately asked to resubmit the iP due to code quality issues.

ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@comp.nus.edu.sg if you want to follow up on this post.