Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS issue for certain external logo image links #3

Closed
lyqht opened this issue Aug 3, 2023 · 2 comments
Closed

CORS issue for certain external logo image links #3

lyqht opened this issue Aug 3, 2023 · 2 comments
Labels
invalid This doesn't seem right

Comments

@lyqht
Copy link
Owner

lyqht commented Aug 3, 2023 •
edited
Loading

If you use any SVG link from Icones, it works as intended, however for certain links like

https://uilicious.com/assets/images/brand/cake_logo.svg

There's a CORS issue
image

This shouldn't happen. Seems to be stemmed from the qr-code-styling library where there's many issues about CORS that are left open.
@lyqht lyqht added the bug Something isn't working label Aug 3, 2023
@lyqht lyqht changed the title CORS issue for certain external logo image links. CORS issue for certain external logo image links Aug 6, 2023
@lyqht lyqht added invalid This doesn't seem right and removed bug Something isn't working labels Aug 6, 2023
@itsAnuga
Copy link
Contributor

Will be hard to make external sites to change their CORS rules ;)

@lyqht
Copy link
Owner Author

lyqht commented Jan 5, 2024

Workaround

If you encounter this issue, a workaround is to just upload ur image for the logo instead of using an external link

@lyqht lyqht closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsAnuga @lyqht