Typo #1
Merged
Typo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,7 @@ private function send(Request $request) | |||
|
|
|||
| $statusCode = $e->getResponse()->getStatusCode(); | |||
| $reasonPhrase = $e->getResponse()->getReasonPhrase(); | |||
| $message = sprintf('The request in not valid (status code: "%d", reason phrase: "%s").', $statusCode, $reasonPhrase); | |||
| $message = sprintf('The request is not valid (status code: "%d", reason phrase: "%s").', $statusCode, $reasonPhrase); | |||
There was a problem hiding this comment.
I guess you broke tests (I test exception message).
You can not see it as you did the patch on github ;)
I will add travis. Could you rebase after my commit for travis ?
Thanks.
lyrixx
added a commit
that referenced
this pull request
Jul 13, 2013
This PR was merged into the master branch. Discussion ---------- Typo Commits ------- a7223f6 Typo
|
Oups, I merged you PR :( |
|
fixed by 46639cd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.