Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS0535 & CS0506 -- Another PR is needed so upstream build will no longer be broken #12

Closed
thomiel opened this issue Jul 1, 2022 · 4 comments

Comments

@thomiel
Copy link

thomiel commented Jul 1, 2022

I got compiler errors when trying to build (both: upstream and in this repo):

CS0535 "GtkImage" doesn't implement the interface member "IImage.ToPlatformImage()"
CS0506 "PlatformCanvas.GetStringSize(string, IFont, float)": The inherited member "AbstractCanvas<PlatformCanvasState>.GetStringSize(string, IFont, float)" can't be overriden because it is not tagged as "virtual" , "abstract" or "override"

Do I still need a more special NuGet package or is it just due to new C# features, because of virtual/override on the GetStringSize() members. (Just messing around with in the .csproj didn't do anything, though).

Is main still the place to be or do you suggest another lytico/* gtk branch?

I really could use some pointers to not get lost...

@thomiel thomiel changed the title CS0535 & CS0506 -- Another PR is needed so upstream build will be no longer be broken CS0535 & CS0506 -- Another PR is needed so upstream build will no longer be broken Jul 1, 2022
@lytico
Copy link
Owner

lytico commented Jul 1, 2022

@lytico
Copy link
Owner

lytico commented Jul 1, 2022

@lytico
Copy link
Owner

lytico commented Jul 1, 2022

DONE: IStringSizeService needs to be implemented. Most of code is in PlatformCanva.Text.cs

@lytico
Copy link
Owner

lytico commented Jul 1, 2022

upstream PR is here: dotnet#469

@lytico lytico closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants