Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC does not sync parameters that are not in the regular parameters list #62

Closed
McArdellje opened this issue Sep 6, 2022 · 4 comments
Closed

Comments

@McArdellje
Copy link

Parameters that are not in the avatar's synced parameter list (e.g. Physbone parameters) are not sent over OSC even though they are sent when using the avatar on the VRChat client

2022-09-06.18-18-39.mp4

If I add any of these physbone parameters to the parameter list then they are sent over OSC (but this should not be required)

@lyuma
Copy link
Owner

lyuma commented Sep 6, 2022

@NotAKidOnSteam also filed this this issue here several months ago: #50
and a PR here: #49 but I didn't quite understand how that PR is supposed to work.

The way it was designed is that Av3Emulator sends all parameters defined in the json file at AppData/LocalLow/VRChat/VRChat/OSC/Avatars/...json
The physbone parameters aren't there by default, but I assume you would need to add them to the json? How are you testing this in VRChat. Are you manually modifying the json file yourself?

I just can't find where it's documented how the PhysBone parameters are supposed to work via OSC.

@NotAKidOnSteam
Copy link
Contributor

Pretty sure they are just output, no saving, input, or configuration.

I don't remember but I believe my pr was to allow myself to input OSC directly from VRChat into av3emulator. Needed it to debug some stuff in-game while viewing the animator in-editor.

@McArdellje
Copy link
Author

@NotAKidOnSteam also filed this this issue here several months ago: #50 and a PR here: #49 but I didn't quite understand how that PR is supposed to work.

The way it was designed is that Av3Emulator sends all parameters defined in the json file at AppData/LocalLow/VRChat/VRChat/OSC/Avatars/...json The physbone parameters aren't there by default, but I assume you would need to add them to the json? How are you testing this in VRChat. Are you manually modifying the json file yourself?

I just can't find where it's documented how the PhysBone parameters are supposed to work via OSC.

I tried adding the Physbone parameters to the config file that Av3 uses, it still did not sync them, but they did show up in the list of what should be synced (I copied the definition of another parameter of the same type and then changed the name and path of it)
In VRChat I am simply deleting the OSC configuration file then toggling OSC to force VRChat to regenerate it, that gets VRChat to sync all of the physbone parameters correctly

@McArdellje
Copy link
Author

out.mp4

Here is an example of the issue (sorry for low quality, there is an upload limit of 10 MB)
Switching between 2 Parameter lists, one containing the physbone parameters, one not, no other options are being changed.
the physbone parameters are in the OSC config file that the emulator is using so they should be synced whether they are in the avatar's synced parameter list or not (as that is the behavior of the VRChat client)

@lyuma lyuma closed this as completed in 9fdc6ac Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants