Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.5.1 breaks Java 9 module system compatibility #137

Closed
eikemeier opened this issue Mar 28, 2019 · 4 comments
Closed

Version 1.5.1 breaks Java 9 module system compatibility #137

eikemeier opened this issue Mar 28, 2019 · 4 comments

Comments

@eikemeier
Copy link

eikemeier commented Mar 28, 2019 •
edited

Before commit 7d7ca2b the automatic module name was lz4.java, which was fine.

Hyphens are not allowed in module (or package) names, so org.lz4.lz4-java isn't valid, therefore not usable as a module.

See also #134 (comment)

Workaround: Revert to 1.5.0.
@odaira
Copy link
Member

odaira commented Mar 28, 2019

Thanks, I'm working on it at #134. The module name should have been something like org.lz4.lz4_java. Do you have any other suggestion?

@eikemeier
Copy link
Author

Actually, I haven't seen underscores in module (or package) names very often.

How about org.lz4.java or simply lz4.java like it is now? You are aiming for org.lz4.lz4.java which will work, but looks strange to me.

@odaira
Copy link
Member

odaira commented May 10, 2019

Fixed by 01a3657. Thanks much for your suggestion!

@odaira
Copy link
Member

odaira commented Sep 11, 2019

Thanks for your bug report. This was fixed by lz4-java 1.6.0.

@odaira odaira closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eikemeier @odaira