You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using this library in a highly concurrent setting - vis. Apache Spark - I'm seeing a lot of contention around this synchronisation block, specifically when called from here
It seems the synchronisation is somewhat redundant and that it can safely be removed, assuming the boolean member loaded is modified to volatile, no?
I can offer a PR if you feel like wise.
The text was updated successfully, but these errors were encountered:
@odaira - it's been a while since this issue was opened... :)
I'm not sure if this problem still persists, but regardless I can open a PR, no problem, I don't think it's harmful.
When using this library in a highly concurrent setting - vis. Apache Spark - I'm seeing a lot of contention around this synchronisation block, specifically when called from here
It seems the synchronisation is somewhat redundant and that it can safely be removed, assuming the boolean member
loaded
is modified to volatile, no?I can offer a PR if you feel like wise.
The text was updated successfully, but these errors were encountered: