Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve meson build system #1062

Closed
vtorri opened this issue Jan 31, 2022 · 6 comments
Closed

improve meson build system #1062

vtorri opened this issue Jan 31, 2022 · 6 comments

Comments

@vtorri
Copy link
Contributor

vtorri commented Jan 31, 2022

it depends if you want to increase meson version from 0.47 to 0.48 for gnu-symbol-visibility

Vincent Torri

@Cyan4973
Copy link
Member

Word of advise regarding version support:
it's generally preferable for build scripts to not be too much reliant on the "bleeding edge" to be effectively used by a diverse ecosystem.
A good rule of thumb is to remain compatible with at least oldest supported Ubuntu LTS version,
which currently is Ubuntu 18.04 Bionic Beaver.

@eli-schwartz
Copy link
Contributor

eli-schwartz commented Feb 1, 2022

You can use features from newer versions of meson using if meson.version().version_compare('>=0.48').

That being said:

A good rule of thumb is to remain compatible with at least oldest supported Ubuntu LTS version,
which currently is Ubuntu 18.04 Bionic Beaver.

The original addition of the meson build script back in 2018 required Meson 0.47, which is too new for Ubuntu 18.04, so bumping that again from 0.47 to 0.48 won't reduce your support.

It is a 3.5 year old release and is broadly available, even if the Ubuntu LTS game offers 5 years of compatibility sometimes people are still willing to sacrifice the oldest one in town in the name of badly needed features.

Depends on what you need, I guess.

@tristan957
Copy link
Contributor

See #1064

@tristan957
Copy link
Contributor

@vtorri would be great if you could give input on the PR since you care about it.

@vtorri
Copy link
Contributor Author

vtorri commented Feb 8, 2022

it depends if the developpers accept to bump the required minimal version of meson

@tristan957
Copy link
Contributor

You should try reading through the PR :)

@vtorri vtorri closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants