Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LZFSE doesn't work on big endian #23

Open
Tracked by #195
nemequ opened this issue Jul 14, 2016 · 3 comments
Open
Tracked by #195

LZFSE doesn't work on big endian #23

nemequ opened this issue Jul 14, 2016 · 3 comments

Comments

@nemequ
Copy link
Contributor

nemequ commented Jul 14, 2016

I'm setting up CI for Squash on POWER8, and LZFSE is one of the codecs which fails. To make sure the issue isn't with Squash, I tried a simple test of just LZFSE:

[fedora@squash-be lzfse]$ ./build/bin/lzfse -encode < README.md | ./build/bin/lzfse -decode
malloc: Cannot allocate memory
[fedora@squash-be lzfse]$ uname -a
Linux squash-be.novalocal 4.5.7-202.fc23.ppc64 #1 SMP Thu Jun 30 10:45:03 UTC 2016 ppc64 ppc64 ppc64 GNU/Linux

There are lots of other errors for LZFSE in the Squash test suite (which is pretty evil) on ppc64be (sample log), so it could be helpful for testing.

If it would help, I can provide access to a VM for testing. Just e-mail me, or drop by #squash on freenode, and we can figure something out.

@nemequ
Copy link
Contributor Author

nemequ commented Sep 1, 2016

I started playing with this, see https://github.com/nemequ/lzfse/tree/endian. I think I have the encoder done (I haven't tested many files, but the ones I have tested provide the same output on LE and BE). Decoder still crashes.

Not sure when I'll have time to finish this up, so if anyone else wants to pick it up feel free.

@juanandresgs
Copy link

Any fix for this?

@Artoria2e5
Copy link

The tree still does not have the endian functions here, so probably not in here yet. I will see if I can do a forward port while adding a test case from a LE amd64-gcc/clang machine, since another pet peeve of mine is about loss of packing information in msvc v2 header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants