Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'secure' cookie option #7

Closed
olsonpm opened this issue Dec 29, 2016 · 3 comments
Closed

'secure' cookie option #7

olsonpm opened this issue Dec 29, 2016 · 3 comments

Comments

@olsonpm
Copy link

olsonpm commented Dec 29, 2016 •
edited

any reason you provided a default for the 'secure' option? the cookies module dynamic default seems more intuitive than your hardcoding of false
@lzztt
Copy link
Owner

lzztt commented Dec 29, 2016 •
edited

Thank you, olsonpm.
It is a very good suggestion. I will remove the default value for the secure option.

@lzztt
Copy link
Owner

lzztt commented Dec 29, 2016

released v3.0.3

@lzztt lzztt closed this as completed Dec 29, 2016
@olsonpm
Copy link
Author

olsonpm commented Dec 29, 2016

Wow - thanks so much.

btw, this module was well written and documented. I had the pleasurable experience of writing code that just worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olsonpm @lzztt