Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose py.typed file #153

Closed
kasium opened this issue Dec 16, 2021 · 4 comments · Fixed by #155
Closed

Expose py.typed file #153

kasium opened this issue Dec 16, 2021 · 4 comments · Fixed by #155
Labels
enhancement New feature or request

Comments

@kasium
Copy link
Contributor

kasium commented Dec 16, 2021

Hey,

would you consider to add a py.typed file so that projects using this project in a programmatic way can benefit from the added type hints?
I'm happy to open a PR.

@kasium kasium added the enhancement New feature or request label Dec 16, 2021
@m-burst
Copy link
Owner

m-burst commented Dec 19, 2021

Hi @kasium, I will gladly accept a PR.

Just out of curiosity, what are you trying to accomplish by using the plugin in a programmatic way?

@kasium
Copy link
Contributor Author

kasium commented Dec 21, 2021

Hi, thanks for this. I created the PR.

Reg. your question: I maintain a project (sadly closed source) which acts as a wrapper around several flake8 plugins. Since I love typing, I would like that mypy can consider your type hints.

@m-burst
Copy link
Owner

m-burst commented Dec 22, 2021

Hi @kasium,
I have just released v1.6.0 which includes the py.typed file.

@kasium
Copy link
Contributor Author

kasium commented Dec 22, 2021

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants