Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bower main section Should use non minified version for correct wiredep behaviour #135

Open
mhawila opened this issue Sep 3, 2015 · 1 comment
Milestone

Comments

@mhawila
Copy link

mhawila commented Sep 3, 2015

When using Grunt wiredep task to wire dependencies I notice the version I pulled from bower (version 5.2.8) had the main section specify the minified version (see below) contrary to "standard" practice. I had to override the property in my bower.json file for it to work properly.

"main": [
"dist/dialogs.min.css",
"dist/dialogs.min.js",
"dist/dialogs-default-translations.min.js"
],

Wouldn't it be nice to modity it to follow the conventions and become

"main": [
"dist/dialogs.css",
"dist/dialogs.js",
"dist/dialogs-default-translations.js"
],

@dougmoscrop
Copy link
Collaborator

I agree - for now you can override this in your own bower.json. I think we should make this a major version change since theoretically some peoples build pipeline might now be assuming that it is minified?

@dougmoscrop dougmoscrop added this to the 6.0.0 milestone Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants