Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese year calculation should take into account full date #23

Closed
koterpillar opened this issue Oct 22, 2020 · 1 comment · Fixed by #24
Closed

Chinese year calculation should take into account full date #23

koterpillar opened this issue Oct 22, 2020 · 1 comment · Fixed by #24
Labels
bug Something isn't working

Comments

@koterpillar
Copy link
Contributor

Years in Chinese lunar calendar ("Chinese zodiac") don't start on January 1. For example, year of the Rat started on January 25, 2020, and therefore someone born on January 10 would still be an Ox.

Birday should implement the lunar calendar properly and show the correct signs.

I've found:

@m-i-n-a-r
Copy link
Owner

Yep, i used an approximation and i forgot to fix it, since it is a bit complicated. I'll look into it as soon as possible, thanks 👍

@m-i-n-a-r m-i-n-a-r added the bug Something isn't working label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants