Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 bugs I found on Firefox Quantum #123

Closed
lonewulfeu opened this issue Nov 16, 2017 · 9 comments
Closed

3 bugs I found on Firefox Quantum #123

lonewulfeu opened this issue Nov 16, 2017 · 9 comments

Comments

@lonewulfeu
Copy link

lonewulfeu commented Nov 16, 2017

First of all thanks for this great plugin.

I noticed 3 issues when using default/invert modes on Firefox Quantum.

  1. Images that open in lightbox on websites do not appear on the center of the screen (they get lost)
  2. When trying to open chatbox in facebook (not messenger) it makes the page scroll down and the chat window is not visible
  3. On some sites youtube embedded video content colors appear "inverted" (can you disable the filter for all videos?)
@jlanza
Copy link

jlanza commented Nov 24, 2017

for 3. in my case most youtube videos doesn't show up. It is just a black square I cannot click. I have to fully disable the extension in order to watch the video (it is not enough with adding the extension to the configured pages)

@m-khvoinitsky
Copy link
Owner

m-khvoinitsky commented Nov 25, 2017

First, make sure that you're using latest add-on version (0.6.6 at the moment).
Always specify which method produces some certain issue. And provide example affected pages, preferably with screenshots.

  1. See above
  2. I guess it's "Invert". That's not related to Quantum. This is a Firefox bug and it exists since something about Firefox 25 — 30. UPD: Firefox bug: after applying filter to an element, all its positioned descendants behave like the element was positioned #126
  3. Provide examples. @jlanza, you too.

(can you disable the filter for all videos?)

It's not that easy in general case.

@lonewulfeu
Copy link
Author

lonewulfeu commented Dec 1, 2017

@m-khvoinitsky

  1. For the lightbox issue, scroll down to the showcase gallery and click on images with the addon enabled:
    http://fancyapps.com/fancybox/3/
    This happens with every lightbox element, fancybox is just an example.

  2. The facebook chatbox bug only happens when the addon is enabled though. Also when you scroll down on facebook the content they have on each side gets lost (more visible on facebook marketplace).
    I think it's a similar issue with 1) when you click on a web element that is supposed to open something, e.g a lightbox or the facebook chatbox it triggers a scroll event for some reason and that makes them disappear or out of place.

@m-khvoinitsky
Copy link
Owner

Both issues caused by #126 (Firefox bug). As I said, it's not related to Quantum, it existed before. All I can recommend is using Stylesheet Processor.

@jlanza
Copy link

jlanza commented Dec 1, 2017

@m-khvoinitsky

  1. Here you have an example [1]. With the extension Enabled I'm not able to see the video, just a blank square. In order to see it, I have to fully disable (unclick Enabled check box), as just only clicking on Disable for a specific website it is not working.

[1] https://www.windowscentral.com/why-windows-tab-sets-game-changer-productivity

@lonewulfeu
Copy link
Author

For me I can see the video above but it's inverted. Only with css it looks correct.

@jlanza
Copy link

jlanza commented Dec 4, 2017

Here you can see my result at [1].

untitled

There is no way to click on it :( What can i do? the only thing is to temporally fully disable the extension.

[1] https://www.espinof.com/trailers/tras-ver-el-primer-teaser-de-jurassic-world-el-reino-caido-necesitamos-un-velociraptor-en-nuestra-vida

@jlanza
Copy link

jlanza commented Dec 21, 2017

The code of the site is like this:

<div class="article-asset-video article-asset-large">
    <div class="asset-content">
       <div class="base-asset-video">
          <iframe width="1000" height="563" src="//www.youtube.com/embed/5DCg7XVuJKY" frameborder="0" allowfullscreen></iframe>
       </div>
    </div>
</div>

It seems that it youtube iframes.

@m-khvoinitsky
Copy link
Owner

I've created separate bug for inverted embedded videos #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants