Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

su-servo: rtio collisions + done #1028

Closed
hartytp opened this issue May 31, 2018 · 1 comment
Closed

su-servo: rtio collisions + done #1028

hartytp opened this issue May 31, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@hartytp
Copy link
Collaborator

hartytp commented May 31, 2018

  • please can you document what the done parameter from get_status means, and how (if at all) it is intended to be used by users?
  • possibly related question: what is the expected behaviour for back-to-back calls (no delay between them) to set_config(enable=0) 'set_config(enable=1)
@jordens jordens self-assigned this May 31, 2018
@jordens jordens added this to the 4.0 milestone May 31, 2018
@jordens
Copy link
Member

jordens commented May 31, 2018

ACK. A couple comments:

  1. Done pulses during regular operation each time a servo iteration is complete. When disabled it becomes permanently asserted when the pending servo cycles are complete.
  2. set_config does not support replacement (unlike the per-channel RTIO control interfaces) and should leave the servo enabled. In t_servo/t_RTIO cases it would delay the next servo cycle by one RTIO cycle (when the restart coincides with the time between the two memory accesses).

@jordens jordens modified the milestone: 4.0 Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants