New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy error when using `from simple_pid import PID` #48

Closed

rnestler opened this issue Apr 21, 2022 · 0 comments · Fixed by #49

Contributor

rnestler commented Apr 21, 2022 •

edited

Loading

When I use from simple_pid import PID and check the code with mypy --strict I get the following error:

$ mypy --strict test.py
test.py:1: error: Module "simple_pid" does not explicitly export attribute "PID"; implicit reexport disabled

I guess this is an issue with the from .PID import PID in __init__.py? If I change it to from .PID import PID as PID it works.

Also I think it is strange that the import in __init__.py shadows the PID module in simple_pid.

Maybe it would be better to rename the module to pid?

The text was updated successfully, but these errors were encountered:

rnestler mentioned this issue

Fix mypy issue by using an explicit export #49

Merged

m-lundberg closed this as completed in #49

m-lundberg mentioned this issue

Rename PID module #53

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment