Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy error simple_pid/PID.pyi:45: error: Name "output_limits" already defined on line 17 #50

Closed
rnestler opened this issue Apr 21, 2022 · 2 comments · Fixed by #51
Closed

mypy error simple_pid/PID.pyi:45: error: Name "output_limits" already defined on line 17 #50

rnestler opened this issue Apr 21, 2022 · 2 comments · Fixed by #51

Comments

@rnestler
Copy link
Contributor

It seems that output_limits is defined twice: Once on line 17 and then again on line 45 and 46.
@rnestler
Copy link
Contributor Author

It would probably be good to run mypy --strict simple_pid during CI to avoid issues like this. Also since Python 2 is EOL you could consider removing Python 2 support and use inline type annotations, which are easier to manage.

@rnestler rnestler mentioned this issue Apr 21, 2022
Merged
@m-lundberg
Copy link
Owner

You are right, mypy should be run in CI to detect things like this. I will create an issue for this.

@m-lundberg m-lundberg mentioned this issue Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate output_limits definition rnestler/simple-pid
2 participants
@rnestler @m-lundberg