New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add a newline at end of files (and minor improvements) #9

Closed

mmzoo wants to merge 5 commits into mryan43:master from bukowskis:master

mmzoo commented Oct 4, 2012

I like your gem :) With the following changes, we actually use it gladly.

Use spaces, not tabs for indentation
Removed a superfluous space in the encoding comment
Use Array#unshift instead of insert(0,...)
Don't append a newline at the end of the file
Add lib to load-path for local testing outside of the gem

mmzoo added 5 commits

October 4, 2012 09:15


          Use spaces, not tabs for indentation


          Removed a superfluous space in the encoding comment

89b2b2c


          Use Array#unshift instead of insert(0,...)

cf041f9


          Don't append a newline at the end of the file

780f3bd


          Add lib to load-path for local testing outside of the gem

9a5a12e

Author

mmzoo commented Nov 13, 2012

Hello? :)

mmzoo closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment