Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TCA code #93

Open
mjancen opened this issue May 15, 2021 · 0 comments
Open

Refactor TCA code #93

mjancen opened this issue May 15, 2021 · 0 comments
Assignees
@mjancen
Labels
minor Minor issue, doesn't necessarily fix functionality but is worth resolving
Projects
Core

Comments

@mjancen
Copy link
Collaborator

mjancen commented May 15, 2021 •
edited

Changes to be made:

  • Combine the "plot_separately" and "plot_together" boolean variables into an Enum. The Enum class better captures the fact that the type of TCA plotting can only take 2 values, not 4.
  • Refactor tca_tvs* functions as there is a lot of duplicated code there.
  • Remove commented code
@mjancen mjancen added the minor Minor issue, doesn't necessarily fix functionality but is worth resolving label May 15, 2021
@mjancen mjancen self-assigned this May 15, 2021
@mjancen mjancen added this to To do in Core via automation May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjancen mjancen

Labels
minor Minor issue, doesn't necessarily fix functionality but is worth resolving
Projects
Core
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjancen