Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better matching for titles with roman numerals #99

Closed
jingai opened this issue Jan 13, 2017 · 2 comments
Closed

Better matching for titles with roman numerals #99

jingai opened this issue Jan 13, 2017 · 2 comments

Comments

@jingai
Copy link
Collaborator

jingai commented Jan 13, 2017

We currently attempt to swap out digits in replaceDigits()/word_form() when fuzzy matching if we didn't get a good match without it (e.g., five and 5), but roman numerals are very common in movie titles too.

In particular, if all that distinguishes one movie from another is the roman numerals, we're likely to either match the wrong movie or none at all.

Take for instance the user requesting: "Alexa, ask Kodi to watch movie back to the future two"

And in the user's library, we have these titles:

Back to the Future
Back to the Future II
Back to the Future III

The fuzzy match currently will stop on and select "Back to the Future" (the first movie).

@jingai
Copy link
Collaborator Author

jingai commented Apr 15, 2017

And this is even more difficult when we're supporting multiple languages... the existing word_form() method only supports English, too.. probably should fix that at some point.

jingai added a commit that referenced this issue Apr 24, 2017
Namely for sequals; e.g., Back to the Future II.

Addresses Issue #99.
@jingai
Copy link
Collaborator Author

jingai commented Apr 24, 2017

This is done and pushed up, but as noted, word form number conversions are only supported for English.

Closing the issue as the language issue is arguably separate.

@jingai jingai closed this as completed Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant