Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake to have /core and @types #56

Closed
m10rten opened this issue Sep 13, 2022 · 5 comments
Closed

Remake to have /core and @types #56

m10rten opened this issue Sep 13, 2022 · 5 comments
Labels
Breaking This is breaking for older versions or features enhancement New feature or request Future planned Planned to do in later release

Comments

@m10rten
Copy link
Owner

m10rten commented Sep 13, 2022

Types take up a lot of space in the package.
To improve this, types need to moved to the @types/validatees package to be created seperately.

creation of a validatees/core package/folder is to split te core feature from the less relevant feature.

users should be able to choose either the validatees/core or the full validatees version.
@types/validatees should include all, and there will be no @types/validatees/core because it will be not worth it.

@m10rten m10rten added enhancement New feature or request Breaking This is breaking for older versions or features labels Sep 13, 2022
@m10rten
Copy link
Owner Author

m10rten commented Sep 13, 2022

@types will be done on Future release since this will require a pull request to the @DefinitelyTyped org.

@m10rten m10rten added the Future planned Planned to do in later release label Sep 13, 2022
@m10rten
Copy link
Owner Author

m10rten commented Sep 18, 2022

/core will require to make an internal package where /core has own package.json and registry.

@m10rten
Copy link
Owner Author

m10rten commented Sep 18, 2022

Same can be done for the CLI in /cli

@m10rten
Copy link
Owner Author

m10rten commented Sep 18, 2022

Where the prefix for both packages could be @validatees

@m10rten
Copy link
Owner Author

m10rten commented Sep 18, 2022

This has been picked up: @jetvil/types replaces ` validatees/types
@jetvil/core sums up core functionality, easy to use.
CLI will be added later on.

custom @types will not be done, since we include types as standard.

@m10rten m10rten closed this as completed Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking This is breaking for older versions or features enhancement New feature or request Future planned Planned to do in later release
Projects
None yet
Development

No branches or pull requests

1 participant