Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing ffmpeg when isn't used #25

Open
rudnypc opened this issue Dec 3, 2021 · 4 comments
Open

Closing ffmpeg when isn't used #25

rudnypc opened this issue Dec 3, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@rudnypc
Copy link

rudnypc commented Dec 3, 2021

The ffmpeg will be killed after 50 segments are created.
But When I start a video with a index file, the vlc start all playlists and some ffmpeg instances are started, this slows down the server, maybe there should be a better control to disable ffmpeg when not used, and when used, increase the limit from 50 to another after new requests, so there is no cut in audio between old and new segments.

@rudnypc
Copy link
Author

rudnypc commented Dec 6, 2021

When the ffmpeg is closed, is the last segment complete?
When I try to kill the ffmpeg, always the last segment is corrupted.

@m1k1o
Copy link
Owner

m1k1o commented Dec 6, 2021

Yes, it does not kill ffmpeg just waits it to finish. That would need to be implemented. What kill signal do you use?

@rudnypc
Copy link
Author

rudnypc commented Dec 6, 2021

I tried "kill -9|HUP|SIGINT", pressing "q"... I saw the ffmpeg command with only "-ss" inside the go-transcode, because this I asked about it.

@m1k1o m1k1o added the enhancement New feature or request label Dec 8, 2021
@rudnypc
Copy link
Author

rudnypc commented Dec 13, 2021

I have tested ffmpeg a lot, the best video process is to keep ffmpeg until the end of the video when getting new segment, you can close ffmpeg only if it asks for a future segment (seek) or if it doesn't request a new segment for a while (timeout ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants