Update SendPOI to include display attributes

[rikroe]

This PR contains some small changes I made when I tried to send not GPS coordinates but failed. However with this changes you can now not only send coordinates but also display information (such as address, city, etc.) like the original app does:

$ bimmerconnected sendpoi -h
usage: bimmerconnected sendpoi [-h] [--name [NAME]] [--street [STREET]] [--city [CITY]]
                      [--postalcode [POSTALCODE]] [--country [COUNTRY]]
                      username password {north_america,china,rest_of_world}
                      vin latitude longitude

send a point of interest to the vehicle

positional arguments:
  username              Connected Drive user name
  password              Connected Drive password
  {north_america,china,rest_of_world}
                        Region of the Connected Drive account
  vin                   vehicle identification number
  latitude              latitude of the POI
  longitude             longitude of the POI

optional arguments:
  -h, --help            show this help message and exit
  --name [NAME]         (optional, display only) Name of the POI
  --street [STREET]     (optional, display only) Street & House No. of the POI
  --city [CITY]         (optional, display only) City of the POI
  --postalcode [POSTALCODE]
                        (optional, display only) Postal code of the POI
  --country [COUNTRY]   (optional, display only) Country of the POI

Overall superb work you're doing! Your implementation works for me on a 3 series F31 with NBT.

I will create a new issue regarding the address only topic with more information, as I'd like your input on some things.

[robthebold]

I tested this with my '17 i3 + Rex. This PR improves on PR#98 by allowing the name parameter to be properly transmitted with the coordinates message. IMO, these PRs should be committed to the master branch -- is there a maintainer in the house who can approve these or at least just take a look at the changes?

[robthebold]

I've been testing this code a little more. When you fill in all the required and optional arguments (lat,lon,name,street,city,postalcode,country) you will get the message delivered to the car with everything but the country populated -- there's one line marked "null".

Here's what it looks like on the display:

And when you open the message:

(This will take you to an art museum in Davenport, IA. Well worth a stop if you're traveling across the US on I-80. Surprisingly extensive collection of Haitian art in addition to the American and Regionalist work you might expect. But I digress. . .)

So I had set the country to "USA" but it's missing in the message and something appears as "null". Clearly something is still not quite working. When I just leave out the country name parameter out (since it's optional) the "null" still appears. So it's not just that "country" is being transmitted wrong.

Even if you leave out everything but the lat and lon (which will then populate the message with the gps coords translated into deg,min,sec in place of the dest name) you still see the "null"

However, the "null" bug notwithstanding, the function is usable.

All the caveats about sending a POI as coords apply: you're not going to a street address, you're going to a point and e.g. that point could be inside a building and your nav may not take you to the front door. Or you could end up somewhere around the block from where you want to be behind a fence from your destination. If you can't be totally sure you're setting the coords properly, it might be safer to search for a POI in the in-car nav near your point.

[gerard33]

Thanks.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.