Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Password visible, keyboard autocorrect & google button remains turned on #136

Closed
JollyMort opened this issue Nov 15, 2017 · 1 comment · Fixed by #139
Closed
Labels

Comments

@JollyMort
Copy link

JollyMort commented Nov 15, 2017

Android 7.1.1.

When creating a new wallet, the password is shown while typing. In addition to this, my autocorrect/google predictive search of the keyboard (gboard) remains turned on as if I'm inputting into any plaintext field. Some other apps correctly recognize/signal that it's sensitive info and automatically disable autocorrect/google predictive search of my keyboard. I don't want google snooping on my passwords.

@jenniferberger
Copy link
Contributor

jenniferberger commented Nov 15, 2017

Indeed that also bugged me during testing, have no suggestions activated but that is a valid issue.

app/src/main/res/layout/fragment_generate.xml:52
-android:inputType="text"
+android:inputType="textVisiblePassword"

should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants