Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to customize UITextView that's created in attributedString configuration of MarkdownTextView #92

Closed
lvnkmn opened this issue May 29, 2019 · 3 comments
Closed

Ability to customize UITextView that's created in attributedString configuration of MarkdownTextView #92

lvnkmn opened this issue May 29, 2019 · 3 comments

Comments

@lvnkmn
Copy link
Collaborator

lvnkmn commented May 29, 2019 •
edited
Loading

Hi there!

It would be really nice if UITextViews created by MarkDownAsAttributedStringViewConfiguration could be further customized just like views created in MarkDownAsViewViewConfiguration can be customized though the public var onDidConvertMarkDownItemToView:((_ markDownItem: MarkDownItem, _ view: UIView) -> Void)? closure.

this way scrolling, contentInsets etc. can be changed as desired.
@lvnkmn
Copy link
Collaborator Author

lvnkmn commented May 29, 2019

I'll create a PR for this in a bit.

@lvnkmn lvnkmn mentioned this issue May 29, 2019
Merged
@Basca
Copy link
Contributor

Basca commented Sep 20, 2019

Released as version 9.2.1: https://github.com/M2Mobi/Marky-Mark/releases/tag/9.2.1

@lvnkmn
Copy link
Collaborator Author

lvnkmn commented Sep 21, 2019

Super. Thanks Bas!

@lvnkmn lvnkmn closed this as completed Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lvnkmn @Basca