The first commit from #44 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cl' is required again for the sake of `lexical-let', but at least for recent Emacsen only at compile time. At runtime `cl' is only required right before the use of `lexical-let', which is on a code path only used by older Emacsen. Also add the `cl-' prefix to some symbols. This completes #43.
|
Thanks. I supposed to cherry-pick the first commit very soon. |
|
I figured you were a bit busy, or something :-) |
|
Sorry. BTW, are you interested in to become a new maintainer of direx? As you said, I don't have much time to work on this project. I can transfer the repo. |
|
No, sorry. I also don't have enough time. |
|
OK. Thanks, anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44 I said you should merge only the first commit, but you merged both. I then pointed out that you should revert the second commit and you reverted both. This new pull request allows you to merge the first commit again - and nothing else.