Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMath does not include Atan2 #18

Closed
Costigan opened this issue Jun 3, 2019 · 5 comments
Closed

XMath does not include Atan2 #18

Costigan opened this issue Jun 3, 2019 · 5 comments
Assignees
Labels
feature A new feature (or feature request)
Milestone

Comments

@Costigan
Copy link

Costigan commented Jun 3, 2019

I'm using version 5.1 installed in a c# project by NuGet.
The upgrade guide for release 5.0 says that GPUMath was replaced by XMath. In doing so, some functions were apparently omitted, including Acos, Asin, Atan and ATan2. The MathIntrinsicKind enumeration still contains that seem to correspond to these functions.

What drove the removal of these functions?
Might they be included again in a future release?
(I'm hoping for .NET Core support but need these functions.)

Btw, this project is very nice to use. Thank you.

@m4rs-mt m4rs-mt self-assigned this Jun 7, 2019
@m4rs-mt m4rs-mt added the feature A new feature (or feature request) label Jun 7, 2019
@m4rs-mt m4rs-mt added this to the v0.7 milestone Jun 13, 2019
@m4rs-mt
Copy link
Owner

m4rs-mt commented Jun 20, 2019

Yes, you're absolutely right. I will restructure these functions in the next release anyway. At this point I will add the missing mathematical functions :)

@Costigan
Copy link
Author

Great. Thank you.

@m4rs-mt
Copy link
Owner

m4rs-mt commented Sep 4, 2019

The new ILGPU.Algorithms library has integrated support for the missing XMath functions.
See https://github.com/m4rs-mt/ILGPU.Algorithms

@m4rs-mt m4rs-mt closed this as completed Sep 4, 2019
@Costigan
Copy link
Author

Costigan commented Nov 16, 2019

Hello. I'm trying to port to 0.6.0. and XMath.Atan2() is missing again. I'm compiling for netcor3.0 and have installed the ILGPU (0.6.0) and ILGPU.Lighting (0.3.0) packages, and XMath.Atan2() is missing. Do I need to install something else?

@m4rs-mt
Copy link
Owner

m4rs-mt commented Nov 16, 2019

@Costigan Atan2 will be available in v0.7. Version v0.6 does not include an Atan2 implementation yet. ILGPU.Algorithms supports XMath.Atan2 for CPU and PTX targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature (or feature request)
Projects
None yet
Development

No branches or pull requests

2 participants