Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with angular 1.2.9? #1

Closed
ThCC opened this issue Sep 5, 2014 · 5 comments
Closed

Problem with angular 1.2.9? #1

ThCC opened this issue Sep 5, 2014 · 5 comments

Comments

@ThCC
Copy link

ThCC commented Sep 5, 2014

Is there any problem in using this version of AngularJS?

@m59peacemaker
Copy link
Owner

@ThCC Some of the current code the the components in this repo aren't supported in that version, but I'm going to push some changes soon that will make them work.

Anyway, the error you're showing doesn't appear to be a problem with anything of mine. That's all angular-route. Did you mean to post your issue somewhere else? If this was intended for me, what component are you using?

@ThCC ThCC changed the title Problem with angular 1.2.0? Problem with angular 1.2.9? Sep 5, 2014
@ThCC
Copy link
Author

ThCC commented Sep 5, 2014

Hi @m59peacemaker, thanks for replying so fast.
I'm checking here and probably the error has nothing to do with your code. So I removed the publication referring to the error.
But I wonder if your code works with version 1.2.9 of the AngularJS. It was my fault, I thought it was 1.2.0, but it's 1.2.9, forgive me.

@m59peacemaker
Copy link
Owner

The only thing I can think of that isn't supported is Validate Custom because I used $validators that are only in the recent 1.3.0 beta-12+, I think. That was a bad design anyway. My updated code just uses $setValidity and works as far back as 1.2.0. When I get some tests written, I'll push the improved code.

@ThCC
Copy link
Author

ThCC commented Sep 5, 2014

Okay. This time "will install your code" without being through the bower ... He updated the AngularJS and it was not something good... at all ...
Anything I will inform you.
Thanks and see ya

@ThCC ThCC closed this as completed Sep 5, 2014
@m59peacemaker
Copy link
Owner

Yeah, this package has a very recent beta release of Angular as a dependency, so I think bower would prompt you to update Angular accordingly. Best to decline that! When I get my tests written, I'll test out different versions and rollback the dependency version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants